Enable strict for Json2Html and remove dead copy (#114)

src/Catalog/NuGet.Services.Metadata.Catalog.csproj

@@ -229,8 +229,6 @@
   <ItemGroup>
     <Content Include="content\d3.v3.min.js" />
     <Content Include="content\further.js" />
-    <Content Include="content\Json2Html.js" />
-    <Content Include="content\Json2HtmlStyle.css" />
     <Content Include="content\jsonld.js" />
     <Content Include="content\Promise.js" />
     <EmbeddedResource Include="xslt\normalizeNuspecNamespace.xslt" />

src/Catalog/content/Json2Html.js

@@ -1,68 +0,0 @@
-var json2html = function (obj) {
-
-    var urlregexp = /^http:|^https:/;
-
-    var is_array = function (value) {
-        return Object.prototype.toString.apply(value) === '[object Array]';
-    }
-
-    var displayValue = function (value) {
-        if (value === null) {
-            return 'null';
-        } else {
-            if (is_array(value)) {
-                return displayArray(value);
-            } else if (typeof value === 'object') {
-                return displayObject(value);
-            } else {
-                switch (typeof value) {
-                    case 'string':
-                        if (urlregexp.test(value)) {
-                            var href = value.replace(/\.json$/, '.html');
-                            href = href.replace(/\.json#/, '.html#');
-                            return '<a class="json2html" href="' + href + '">"' + value + '"</a>';
-                        }
-                        else {
-                            return '<span class="json-prop-value-string">"' + value + '"</span>';
-                        }
-                    case 'number': return value.toString();
-                    case 'boolean': return value.toString();
-                    default: throw 'unrecognized value type';
-                }
-            }
-        }
-    }
-
-    var displayObject = function (obj) {
-        var html = '{';
-        html += '<ul class="json-ul">';
-        for (var prop in obj) {
-            html += '<li class="json-li"><span class="json-prop-name">"' + prop + '"</span> : ';
-            html += displayValue(obj[prop]);
-            html += ',</li>';
-        }
-        html = html.slice(0, html.length - 6);
-        html += '</li></ul>';
-        html += '}';
-        return html;
-    }
-
-    var displayArray = function (array) {
-        if (array.length === 0) {
-            return '[]';
-        }
-        var html = '[';
-        html += '<ul class="json-ul">';
-        for (var i = 0; i < array.length; i += 1) {
-            html += '<li class="json-li">';
-            html += displayValue(array[i]);
-            html += ',</li>';
-        }
-        html = html.slice(0, html.length - 1);
-        html += '</li></ul>';
-        html += ']';
-        return html;
-    }
-
-    return displayValue(obj);
-}

src/Catalog/content/Json2HtmlStyle.css

@@ -1,18 +0,0 @@
-.json-ul
-{
-    list-style-type: none;
-    padding: 0px;
-    margin: 0px;
-}
-.json-li
-{
-    padding-left: 28px; 
-    font-family:Consolas;
-    font-size:small;
-}
-.json-prop-name {
-    color: blue;
-}
-.json-prop-value-string {
-    color: red;
-}

src/NuGet.Services.BasicSearch/Console/Json2Html.js

@@ -1,4 +1,5 @@
 var json2html = function (obj) {
+    "use strict";
 
     var urlregexp = /^http:|^https:/;