From 564e8802a8f1a8c92d3c46686b109dfb826856fe Mon Sep 17 00:00:00 2001
From: Gary Yao <gary@apache.org>
Date: Thu, 21 May 2020 09:44:33 +0200
Subject: [PATCH] [FLINK-13553][qs] Add logging to AbstractServerHandler

Log every request on trace level.
Log caught exceptions in AsyncRequestTask.
---
 .../flink/queryablestate/network/AbstractServerHandler.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
index 4115fd96dc8..9011bb27a14 100644
--- a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
+++ b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
@@ -110,6 +110,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
 			final MessageType msgType = MessageSerializer.deserializeHeader(buf);
 
 			requestId = MessageSerializer.getRequestId(buf);
+			LOG.trace("Handling request with ID {}", requestId);
 
 			if (msgType == MessageType.REQUEST) {
 
@@ -263,6 +264,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
 					write.addListener(new RequestWriteListener());
 
 				} catch (BadRequestException e) {
+					LOG.debug("Bad request (request ID = {})", requestId, e);
 					try {
 						stats.reportFailedRequest();
 						final ByteBuf err = MessageSerializer.serializeRequestFailure(ctx.alloc(), requestId, e);
@@ -271,6 +273,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
 						LOG.error("Failed to respond with the error after failed request", io);
 					}
 				} catch (Throwable t) {
+					LOG.error("Error while handling request with ID {}", requestId, t);
 					try {
 						stats.reportFailedRequest();